clippy: Fix redundant_*
warnings
#32056
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
redundant_*
clippy warnings. Also updates the spec comments in the files changed to be propper rustdoc.redundant_file_names
: Removes duplicate field names in struct initialization to avoid.redundant_closure
: Functions can be passed directly instead of wrapping them in a closure.redundant_pattern_matching
:is_ok
andis_err
can be used instead. Here the only part I'm unsure is what to do about the steps incomponents/script/dom/url.rs
, since this merges step 2.2 and 3 together.redundant_guards
: The pattern can be added directly to theSome(...)
pattern instead of checked with an extraif
../mach build -d
does not report any errors./mach test-tidy
does not report any errors