-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement attributes for the <meter>
element
#32230
Conversation
550a5ec
to
740bca5
Compare
🔨 Triggering try run (#8967676784) for Linux WPT |
Test results for linux-wpt-layout-2020 from try job (#8967676784): Flaky unexpected result (23)
Stable unexpected results that are known to be intermittent (18)
Stable unexpected results (3)
|
Test results for linux-wpt-layout-2013 from try job (#8967676784): Flaky unexpected result (12)
Stable unexpected results that are known to be intermittent (14)
Stable unexpected results (3)
|
|
740bca5
to
c0e8bee
Compare
[meter.value: IDL set to -0] | ||
expected: FAIL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently some setters do not work correctly (maybe wrong parsing?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not responding to this comment yet but I went down a rabbit hole, I switched the setter implementations to parse_floating_point_number
before setting the value, but the issue persisted.
I'm really unsure if this is something in parse_floating_point_number
or not :/
Spidermonkey's parseFloat(-0.0)
returns 0
. But our implementation returns -0.0 - do you think this might be a factor or am I barking up the wrong tree?
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that our parse_floating_point_number is wrong, but we can leave this for follow up. In firefox the corresponding function is actually https://searchfox.org/mozilla-central/source/dom/base/nsAttrValue.cpp#1892 (you can see it's only used on progress and meter element just like ours).
For reference, impl in firefox: https://searchfox.org/mozilla-central/source/dom/html/HTMLMeterElement.cpp |
c0e8bee
to
48aa090
Compare
🔨 Triggering try run (#9030565993) for Linux WPT |
Test results for linux-wpt-layout-2013 from try job (#9030565993): Flaky unexpected result (15)
Stable unexpected results that are known to be intermittent (10)
|
Test results for linux-wpt-layout-2020 from try job (#9030565993): Flaky unexpected result (13)
Stable unexpected results that are known to be intermittent (9)
|
✨ Try run (#9030565993) succeeded. |
Thank you! |
Implement attributes for the html
<meter>
element.https://html.spec.whatwg.org/multipage/form-elements.html#the-meter-element
./mach build -d
does not report any errors./mach test-tidy
does not report any errors