Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent results in /css/css-fonts/variations/font-weight-matching.html #20686

Closed
nox opened this issue Apr 24, 2018 · 1 comment · Fixed by #32164 or #32366
Closed

Intermittent results in /css/css-fonts/variations/font-weight-matching.html #20686

nox opened this issue Apr 24, 2018 · 1 comment · Fixed by #32164 or #32366
Labels
I-intermittent Problem reproduces intermittently.

Comments

@nox
Copy link
Contributor

nox commented Apr 24, 2018 

  ▶ Unexpected subtest result in /css/css-fonts/variations/font-weight-matching.html:
  └ PASS [expected FAIL] Test @font-face matching for weight 470

  ▶ Unexpected subtest result in /css/css-fonts/variations/font-weight-matching.html:
  │ FAIL [expected PASS] Test @font-face matching for weight 99
  │   → assert_approx_equals: @font-face should be mapped to CSSTest Weights 900. expected 90 +/- 2 but got 180
  │ FAIL [expected PASS] Test @font-face matching for weight 100
  │   → assert_approx_equals: @font-face should be mapped to CSSTest Weights 900. expected 90 +/- 2 but got 180
  │ FAIL [expected PASS] Test @font-face matching for weight 249
  │   → assert_approx_equals: @font-face should be mapped to CSSTest Weights 900. expected 90 +/- 2 but got 180
  │ 
  └ @http://web-platform.test:8000/css/css-fonts/variations/font-weight-matching.html:128:65
@nox nox added the I-intermittent Problem reproduces intermittently. label Apr 24, 2018
@nox nox mentioned this issue Apr 24, 2018
Merged
This was referenced Apr 12, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions github-actions bot mentioned this issue Jun 22, 2023
Merged
4 tasks
@github-actions github-actions bot mentioned this issue Aug 22, 2023
Merged
This was referenced Aug 29, 2023
Merged
Merged
Merged
This was referenced Sep 5, 2023
Merged
Merged
Merged
Merged
This was referenced Sep 13, 2023
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions github-actions bot mentioned this issue Sep 20, 2023
Merged
3 tasks
This was referenced Apr 15, 2024
Merged
Merged
Draft
Merged
Merged
@github-actions github-actions bot mentioned this issue Apr 26, 2024
Merged
3 tasks
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 27, 2024
@mrobinson @mukilan
fonts: Add support for more @font-face features
dfacc34 
This change adds initial support for the CSS font fallback algorithm
[^1]. There are a couple major changes here:

1. Support is added for the `weight`, `style`, `stretch` and
   `unicode-range` declarations in `@font-face`.
2. Font matching in the font cache can return templates and
   `FontGroupFamily` can own mulitple templates. This is due to needing
   support for "composite fonts". These are `@font-face` declarations
   that only differ in their `unicode-range` definition.

This fixes a lot of non-determinism in font selection especially when
dealing with pages that define "composite faces." A notable example of
such a page is servo.org, which now consistently displays the correct
web font.

One test starts to fail due to an uncovered bug, but this will be fixed
in a followup change.

Fixes servo#20686.
Fixes servo#20684.

Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com>
@mrobinson mrobinson mentioned this issue Apr 27, 2024
Merged
3 tasks
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 27, 2024
@mrobinson @mukilan
fonts: Add support for more @font-face features
c18f6d7 
There are a couple major changes here:

1. Support is added for the `weight`, `style`, `stretch` and
   `unicode-range` declarations in `@font-face`.
2. Font matching in the font cache can return templates and
   `FontGroupFamily` can own mulitple templates. This is due to needing
   support for "composite fonts". These are `@font-face` declarations
   that only differ in their `unicode-range` definition.

This fixes a lot of non-determinism in font selection especially when
dealing with pages that define "composite faces." A notable example of
such a page is servo.org, which now consistently displays the correct
web font.

One test starts to fail due to an uncovered bug, but this will be fixed
in a followup change.

Fixes servo#20686.
Fixes servo#20684.

Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com>
@github-actions github-actions bot mentioned this issue Apr 29, 2024
Merged
3 tasks
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 29, 2024
@mrobinson @mukilan
fonts: Add support for more @font-face features
fdf8067 
There are a couple major changes here:

1. Support is added for the `weight`, `style`, `stretch` and
   `unicode-range` declarations in `@font-face`.
2. Font matching in the font cache can return templates and
   `FontGroupFamily` can own mulitple templates. This is due to needing
   support for "composite fonts". These are `@font-face` declarations
   that only differ in their `unicode-range` definition.

This fixes a lot of non-determinism in font selection especially when
dealing with pages that define "composite faces." A notable example of
such a page is servo.org, which now consistently displays the correct
web font.

One test starts to fail due to an uncovered bug, but this will be fixed
in a followup change.

Fixes servo#20686.
Fixes servo#20684.

Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com>
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 29, 2024
@mrobinson @mukilan
fonts: Add support for more @font-face features
baf4a9e 
There are a couple major changes here:

1. Support is added for the `weight`, `style`, `stretch` and
   `unicode-range` declarations in `@font-face`.
2. Font matching in the font cache can return templates and
   `FontGroupFamily` can own mulitple templates. This is due to needing
   support for "composite fonts". These are `@font-face` declarations
   that only differ in their `unicode-range` definition.

This fixes a lot of non-determinism in font selection especially when
dealing with pages that define "composite faces." A notable example of
such a page is servo.org, which now consistently displays the correct
web font.

One test starts to fail due to an uncovered bug, but this will be fixed
in a followup change.

Fixes servo#20686.
Fixes servo#20684.

Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com>
github-merge-queue bot pushed a commit that referenced this issue Apr 29, 2024
@mrobinson @mukilan
fonts: Add support for more @font-face features (#32164)
4732da3 
There are a couple major changes here:

1. Support is added for the `weight`, `style`, `stretch` and
   `unicode-range` declarations in `@font-face`.
2. Font matching in the font cache can return templates and
   `FontGroupFamily` can own mulitple templates. This is due to needing
   support for "composite fonts". These are `@font-face` declarations
   that only differ in their `unicode-range` definition.

This fixes a lot of non-determinism in font selection especially when
dealing with pages that define "composite faces." A notable example of
such a page is servo.org, which now consistently displays the correct
web font.

One test starts to fail due to an uncovered bug, but this will be fixed
in a followup change.

Fixes #20686.
Fixes #20684.

Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com>
@mrobinson
Copy link
Member

Looks like this is still an issue.

@mrobinson mrobinson reopened this Apr 30, 2024
This was referenced Apr 30, 2024
Closed
Merged
Merged
Merged
Merged
This was referenced May 16, 2024
Merged
Merged
mrobinson added a commit to mrobinson/servo that referenced this issue May 24, 2024
@mrobinson @mukilan
fonts: Add support for the CSS font matching algorithm
4eacce7 
This is a port from Gecko of the CSS font matching algorithm distance
functions as well as the "simple family" concept for optimizing
matching when dealing with simple fonts.

Fixes servo#189.
Fixes servo#190.
Fixes servo#20686.
Fixes servo#20684.

Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com>
Signed-off-by: Martin Robinson <mrobinson@igalia.com>
@mrobinson mrobinson mentioned this issue May 24, 2024
Merged
3 tasks
mrobinson added a commit to mrobinson/servo that referenced this issue May 24, 2024
@mrobinson @mukilan
fonts: Add support for the CSS font matching algorithm
2259239 
This is a port from Gecko of the CSS font matching algorithm distance
functions as well as the "simple family" concept for optimizing
matching when dealing with simple fonts.

Fixes servo#189.
Fixes servo#190.
Fixes servo#20686.
Fixes servo#20684.

Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com>
Signed-off-by: Martin Robinson <mrobinson@igalia.com>
mrobinson added a commit to mrobinson/servo that referenced this issue May 24, 2024
@mrobinson @mukilan
fonts: Add support for the CSS font matching algorithm
ab90b39 
This is a port from Gecko of the CSS font matching algorithm distance
functions as well as the "simple family" concept for optimizing
matching when dealing with simple fonts.

Fixes servo#189.
Fixes servo#190.
Fixes servo#20686.
Fixes servo#20684.

Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com>
Signed-off-by: Martin Robinson <mrobinson@igalia.com>
mrobinson added a commit to mrobinson/servo that referenced this issue May 24, 2024
@mrobinson @mukilan
fonts: Add support for the CSS font matching algorithm
4e199dd 
This is a port from Gecko of the CSS font matching algorithm distance
functions as well as the "simple family" concept for optimizing
matching when dealing with simple fonts.

Fixes servo#189.
Fixes servo#190.
Fixes servo#20686.
Fixes servo#20684.

Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com>
Signed-off-by: Martin Robinson <mrobinson@igalia.com>
github-merge-queue bot pushed a commit that referenced this issue May 24, 2024
@mrobinson @mukilan
fonts: Add support for the CSS font matching algorithm (#32366)
60a81a7 
* fonts: Add support for the CSS font matching algorithm

This is a port from Gecko of the CSS font matching algorithm distance
functions as well as the "simple family" concept for optimizing
matching when dealing with simple fonts.

Fixes #189.
Fixes #190.
Fixes #20686.
Fixes #20684.

Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com>
Signed-off-by: Martin Robinson <mrobinson@igalia.com>

* Ensure that simple faces are removed for removed stylesheets

---------

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-intermittent Problem reproduces intermittently.
Projects
None yet
Milestone
No milestone
2 participants
@mrobinson @nox