Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement atob and btoa methods for worker #3387

Merged
merged 1 commit into from
Sep 17, 2014

Conversation

prasoon2211
Copy link

Moved the Atob and Btoa methods ouside the impl for WorkerMethod trait and made them publicly accessible from WorkerGlobalScopeMethods via proxy methods.

The webidl file already contained the implements line and all I did there was uncomment the line with WorkerGlobalScope implements WindowBase64. I don't know if that does it but running make -f makefile.cargo worked just fine and mach build did not complain about method declaration not being present in the trait definition so I believe it worked fine.

Fixes issue #3238

Moved the Atob and Btoa methods ouside the impl for WorkerMethod trait
and made them publicly accessible from WorkerGlobalScopeMethods via
proxy methods.
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/2617

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@highfive
Copy link

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @kmcallister (or someone else) soon.

@prasoon2211 prasoon2211 changed the title Fix for issue #3238 Implement atob and btoa methods for worker Sep 17, 2014
@jdm
Copy link
Member

jdm commented Sep 17, 2014

Solid! If the tests pass, this is ready to merge.

jdm added a commit that referenced this pull request Sep 17, 2014
Implement atob and btoa methods for worker
@jdm jdm merged commit 61642d6 into servo:master Sep 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants