Implement atob and btoa methods for worker #3387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the Atob and Btoa methods ouside the impl for WorkerMethod trait and made them publicly accessible from WorkerGlobalScopeMethods via proxy methods.
The webidl file already contained the
implements
line and all I did there was uncomment the line withWorkerGlobalScope implements WindowBase64
. I don't know if that does it but runningmake -f makefile.cargo
worked just fine andmach build
did not complain about method declaration not being present in the trait definition so I believe it worked fine.Fixes issue #3238