Improve the correctness of Root lifetimes #3493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new lifetime bounds feature of Rust to enforce that the RootCollection field of Root outlives the jsref field. This still doesn't enforce that the Root itself outlives the jsref field, and doing this would require some sort of init dance.
|
Critic review: https://critic.hoppipolla.co.uk/r/2703 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
r? @jdm |
bors-servo
pushed a commit
that referenced
this pull request
Sep 26, 2014
Improve the correctness of Root lifetimes Reviewed-by: jdm
bors-servo
pushed a commit
that referenced
this pull request
Sep 27, 2014
Improve the correctness of Root lifetimes Reviewed-by: jdm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new lifetime bounds feature of Rust to enforce that the
RootCollection field of Root outlives the jsref field. This still
doesn't enforce that the Root itself outlives the jsref field, and
doing this would require some sort of init dance.