Implement basic form control support #3520
Conversation
|
Critic review: https://critic.hoppipolla.co.uk/r/2724 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
|
| mem::transmute::<&RefCell<Option<String>>, &Option<String>>(&(*input.unsafe_get()).value).clone() | ||
| } | ||
|
|
||
| match (*self.unsafe_get()).input_type.get() { |
There was a problem hiding this comment.
Can you use generated content in the UA stylesheet here instead? input[checked="checked"] { content: ... }
|
I've switched to generated content; the disadvantage is that it can now be split whereas previously I don't think it could. At least that's the difference I see on http://tim.dreamwidth.org/ (look at the Remember Me checkbox). |
| pub enum InputFragmentInfo { | ||
| InputButton(u32), | ||
| InputText(u32), | ||
| InputCheckbox, |
There was a problem hiding this comment.
Doesn't look like most of these are strictly needed at the moment. Can we use GenericFragment instead for InputCheckbox and InputRadioButton and collapse the InputButton/InputText/InputFile down into one?
|
r=me for the layout parts, it's nice and minimal now. Thanks! 👍 |
|
@Manishearth Feel like reviewing the DOM stuff? |
|
Done. |
… when clicking, and flush pending layout changes after dispatching the event.
…glyph as a best guess.
… Implement simple interaction for checkboxes and radio buttons.
… and radio buttons. Switching to the glyph 0 for the average advance width.
So far the changes to layout seem fairly well-contained; I think this is worth integrating to give us a browser that is easier to dogfood (and allows us to work on things like form submission much easier), especially since the long-term viability of WebComponents-as-forms is not assured.
So far the changes to layout seem fairly well-contained; I think this is worth integrating to give us a browser that is easier to dogfood (and allows us to work on things like form submission much easier), especially since the long-term viability of WebComponents-as-forms is not assured.
So far the changes to layout seem fairly well-contained; I think this is worth integrating to give us a browser that is easier to dogfood (and allows us to work on things like form submission much easier), especially since the long-term viability of WebComponents-as-forms is not assured.