Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedding: remove eutil::fptr_is_null, fix #3967, add Option<> to fptrs #3984

Merged
merged 3 commits into from
Nov 15, 2014

Conversation

zmike
Copy link
Contributor

@zmike zmike commented Nov 14, 2014

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/3169

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@zmike
Copy link
Contributor Author

zmike commented Nov 14, 2014

Updated

@jdm
Copy link
Member

jdm commented Nov 14, 2014

I left a critic review but apparently you force-pushed over this commit in the past :(

@zmike
Copy link
Contributor Author

zmike commented Nov 14, 2014

I saw the critic review and addressed the match suggestions (though I can't compile it now because cargo is broken).

I'm not going to fix the indentation issues now because 1) the entire file has this formatting 2) the entire file will become generated code in the near future. It's a waste of time.

@jdm
Copy link
Member

jdm commented Nov 14, 2014

Fair enough.

@bors-servo bors-servo closed this Nov 15, 2014
@bors-servo bors-servo merged commit 5f10092 into servo:master Nov 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants