Switch android to using glutin. Remove GLUT port. #4115
Conversation
|
Critic review: https://critic.hoppipolla.co.uk/r/3294 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
r? @mbrubeck and/or @larsbergstrom |
| @@ -1,4 +1,3 @@ | |||
| /.cargo/config | |||
There was a problem hiding this comment.
Is it possible to not do this and have .cargo/config be in a subdirectory, like in #4099?
There was a problem hiding this comment.
It could possibly go in ports/glutin - I'll test that on android this morning and update the PR.
There was a problem hiding this comment.
Unfortunately that doesn't get picked up by cargo, since android is now built like all other projects from the root of the source tree :(
There was a problem hiding this comment.
I think #4140 could help with that. Whichever lands first, I can help rebasing the other one.
jdm
added
S-awaiting-review
|
I'm going to close this PR and re-open a new one after rebasing - too much has changed during the last week or so with android + ssl etc. |
|
As mentioned in Critic comments, please consider making android-rs-glue a Cargo dependency, or if that doesn’t work a git-submodule. Having mach manually clone and build it seems like reinventing mechanisms that already exist. |
NOTE: This shouldn't be merged until servo/android-rs-glue#1 has been merged.