layout: Implement CSS transitions per CSS-TRANSITIONS § 2. #5400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Critic review: https://critic.hoppipolla.co.uk/r/4391 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
jdm
added
S-awaiting-review
|
@pcwalton Reviewed on critic |
jdm
added
S-needs-code-changes
pcwalton
force-pushed
the
transitions-redux
branch
from
8e2a444
to
4ea5d42
Compare
|
r? @glennw |
|
@pcwalton critic review is accepted, squash and good to go! |
jdm
added
S-needs-squash
Transition events are not yet supported, and the only animatable properties are `top`, `right`, `bottom`, and `left`. However, all other features of transitions are supported. There are no automated tests at present because I'm not sure how best to test it, but three manual tests are included.
pcwalton
force-pushed
the
transitions-redux
branch
from
4ea5d42
to
66dd8c8
Compare
bors-servo
pushed a commit
that referenced
this pull request
Mar 31, 2015
Transition events are not yet supported, and the only animatable properties are `top`, `right`, `bottom`, and `left`. However, all other features of transitions are supported. There are no automated tests at present because I'm not sure how best to test it, but three manual tests are included. r? @glennw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transition events are not yet supported, and the only animatable
properties are
top,right,bottom, andleft. However, all otherfeatures of transitions are supported. There are no automated tests at
present because I'm not sure how best to test it, but three manual tests
are included.
r? @glennw