Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused ScriptDevtoolControlMsg enum #5818

Merged
merged 1 commit into from
Apr 24, 2015
Merged

Remove unused ScriptDevtoolControlMsg enum #5818

merged 1 commit into from
Apr 24, 2015

Conversation

Jinwoo-Song
Copy link
Contributor

Simple patch to remove unused enum, ScriptDevtoolControlMsg.

r? @jdm
cc @yichoi

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 24, 2015
@highfive
Copy link

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @mbrubeck (or someone else) soon.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/4779

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Jinwoo-Song Jinwoo-Song mentioned this pull request Apr 24, 2015
Closed
@mbrubeck
Copy link
Contributor

Reviewed files:

  • components/devtools_traits/lib.rs @ r1

Comments from the review on Reviewable.io

@mbrubeck
Copy link
Contributor

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit df406b9 has been approved by mbrubeck

@bors-servo
Copy link
Contributor

⌛ Testing commit df406b9 with merge ef1e50a...

bors-servo pushed a commit that referenced this pull request Apr 24, 2015
Auto merge of #5818 - Jinwoo-Song:removeUnused, r=mbrubeck
ef1e50a 
Simple patch to remove unused enum, ScriptDevtoolControlMsg.

r? @jdm
cc @yichoi

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5818)
<!-- Reviewable:end -->
@mbrubeck mbrubeck self-assigned this Apr 24, 2015
@mbrubeck mbrubeck added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 24, 2015
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2

@bors-servo bors-servo merged commit df406b9 into servo:master Apr 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Jinwoo-Song @highfive @hoppipolla-critic-bot @mbrubeck @bors-servo