Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump rust-url version: 0.2.16 → 0.2.35 #6286

Merged
merged 1 commit into from
Jun 4, 2015
Merged

Bump rust-url version: 0.2.16 → 0.2.35 #6286

merged 1 commit into from
Jun 4, 2015

Conversation

frewsxcv
Copy link
Contributor

@frewsxcv frewsxcv commented Jun 4, 2015

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 4, 2015
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/5189

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm
Copy link
Member

jdm commented Jun 4, 2015

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit a14c745 has been approved by jdm

@jdm
Copy link
Member

jdm commented Jun 4, 2015

@bors-servo: r-

@jdm
Copy link
Member

jdm commented Jun 4, 2015

This should really include the updates to the various Cargo.lock files, too.

@jdm
Copy link
Member

jdm commented Jun 4, 2015

@bors-servo: r+
My mistake, those files are already ahead here.

@bors-servo
Copy link
Contributor

📌 Commit a14c745 has been approved by jdm

@jdm jdm added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 4, 2015
@frewsxcv
Copy link
Contributor Author

frewsxcv commented Jun 4, 2015

Huh. I would have figured Cargo would complain since (prior to this PR) our packages require 0.2.16 and hyper required 0.2.35. If you have any insight into that, I'm curious

bors-servo pushed a commit that referenced this pull request Jun 4, 2015
Auto merge of #6286 - frewsxcv:bump-url, r=jdm
ad5846f 
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6286)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

⌛ Testing commit a14c745 with merge ad5846f...

@frewsxcv
Copy link
Contributor Author

frewsxcv commented Jun 4, 2015

Answer to my question:

Caret requirements allow SemVer compatible updates to a specified version, 0.1 and 0.2 are not considered compatible, but 1.0 and 1.1 are for example. If no operator is specified, this is the default requirement (e.g. 1.3 is the same as ^1.3).

http://doc.crates.io/crates-io.html

@SimonSapin
Copy link
Member

@frewsxcv, because of that Cargo behaviour, you only need to change the requirements in Cargo.toml if you’re using a e.g. new feature that was introduced in that version. If you just want to update, ./mach update-cargo -p url is enough. (It’ll change Cargo.lock files.)

@frewsxcv
Copy link
Contributor Author

frewsxcv commented Jun 4, 2015

@SimonSapin Yeah, I learned that after I opened this PR. Thanks for the information

@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2

@bors-servo bors-servo merged commit a14c745 into servo:master Jun 4, 2015
@frewsxcv frewsxcv deleted the bump-url branch October 9, 2015 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@frewsxcv @hoppipolla-critic-bot @jdm @bors-servo @SimonSapin @highfive