Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gleam to 0.1.6 #6830

Closed
wants to merge 1 commit into from
Closed

Update gleam to 0.1.6 #6830

wants to merge 1 commit into from

Conversation

emilio
Copy link
Member

@emilio emilio commented Jul 29, 2015

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 29, 2015
@emilio emilio mentioned this pull request Jul 29, 2015
Merged
@jdm
Copy link
Member

jdm commented Jul 29, 2015

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 758b94b has been approved by jdm

@jdm jdm added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 29, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit 758b94b with merge 51bca62...

bors-servo pushed a commit that referenced this pull request Jul 30, 2015
Auto merge of #6830 - ecoal95:gleam, r=jdm
51bca62 
Update gleam to 0.1.6



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6830)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - android

@metajack metajack added S-tests-failed The changes caused existing tests to fail. S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 30, 2015
@metajack
Copy link
Contributor

@glennw Is this from the glutin update that just landed?

@glennw
Copy link
Member

glennw commented Jul 30, 2015

@metajack Ah, those gl functions must not exist on android - gleam will need to be changed to not(android) them.

@metajack
Copy link
Contributor

Superceded by #6845

@metajack metajack closed this Jul 30, 2015
@SimonSapin SimonSapin removed the S-tests-failed The changes caused existing tests to fail. label Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-needs-code-changes Changes have not yet been made that were requested by a reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@emilio @jdm @bors-servo @metajack @glennw @SimonSapin @highfive