-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update euclid to 0.3 #8241
Update euclid to 0.3 #8241
Conversation
Manishearth
commented
Oct 28, 2015
@bors-servo r+ Note: The extra version of glutin was added because of servo/surfman#30 but is only used on Windows currently, and I don't think it'll cause any conflicts even there. Long-term, we should move Servo back to upstream glutin... |
📌 Commit 184b2ba has been approved by |
Update euclid to 0.3 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8241) <!-- Reviewable:end -->
The other question I had was about cocoa on gonk. Reviewed 24 of 24 files at r1, 16 of 16 files at r2. ports/gonk/Cargo.lock, line 215 [r1] (raw file): ports/gonk/Cargo.lock, line 674 [r1] (raw file): Comments from the review on Reviewable.io |
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks pending. ports/gonk/Cargo.lock, line 215 [r1] (raw file): ports/gonk/Cargo.lock, line 674 [r1] (raw file): Comments from the review on Reviewable.io |
☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt |
@mbrubeck It should be fixed in servo/surfman#33. |