implement console.group(), console.groupEnd()

[ajnirp]

Fixes #9274

[ajnirp]

rebased

[jdm]

I doubt we want to apply the indentation to the message before sending it to the devtools client, but I haven't looked carefully at this code yet. Have you tried out the changes with the Firefox webconsole connected?

[paulrouget]

Also, please add groupCollapsed.

[jdm]

Note, instructions for interacting with the Firefox devtools exist in the wiki.

[bors-servo]

☔ The latest upstream changes (presumably #9339) made this pull request unmergeable. Please resolve the merge conflicts.

[asajeffrey]

Some comments on reviewable...

---

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

---

components/devtools/lib.rs, line 339 [r1] (raw file):
This is adding 2 spaces per indent level, and the indent level is incremented/decremented by 2 on each Group/GroupEnd, so there's 4 spaces per event. Is this intended?

---

components/devtools/lib.rs, line 352 [r1] (raw file):
There should be a way to do this without copying the indent string.

---

components/devtools_traits/lib.rs, line 220 [r1] (raw file):
It's a bit odd that Group and GroupEnd are considered to be LogLevels. Is this what devtools does?

---

components/script/dom/console.rs, line 47 [r1] (raw file):
Should all messages be printed to stdout, irrespective of log level?

---

Comments from the review on Reviewable.io

[jdm]

@wenderen Are you planning to continue working on this?

[asajeffrey]

@wenderen is this PR still open?

[ajnirp]

@jdm @asajeffrey It is. I'm very sorry but I cannot work on this because of a lack of free time. Please assign this to someone else if need be.

[asajeffrey]

@wenderen OK, thanks for letting us know!