-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump parking_lot to 0.12 in order to not create wasm export #254
Conversation
@bors-servo r+ |
📌 Commit cbd1dc3 has been approved by |
fix: bump parking_lot to 0.12 in order to not create wasm export parking_lot 0.11 was using parking_lot_core 0.8 which was creating a wasm export when targeting wasm: Amanieu/parking_lot#269 This bumps to parking_lot 0.12, which uses parking_lot_core 0.9 which doesn't have the issue where it creates the wasm export.
💔 Test failed - checks-github |
Failed because of use of Current rust version is 1.58.1, CI is on 1.40. Is it an issue to upgrade to 1.49? |
I'm guessing it doesn't work when I do it, but worth a try 😄 @bors-servo r+ |
@dsherret: 🔑 Insufficient privileges: Not in reviewers |
@bors-servo r+ |
📌 Commit 6c0f825 has been approved by |
☀️ Test successful - checks-github |
Is there a plan to publish a new version for this change? The version on crates.io is still using parking_lot 0.11. |
0.8.4 Would like to get #254
Published. |
parking_lot 0.11 was using parking_lot_core 0.8 which was creating a wasm export when targeting wasm: Amanieu/parking_lot#269
This bumps to parking_lot 0.12, which uses parking_lot_core 0.9 which doesn't have the issue where it creates the wasm export.