Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement From<&str> for Tendril #32

Open
nikhilshagri opened this issue Jun 13, 2017 · 4 comments
Open

Implement From<&str> for Tendril #32

nikhilshagri opened this issue Jun 13, 2017 · 4 comments

Comments

@nikhilshagri
Copy link
Contributor

Currently, the FromStr trait is implemented for Tendril, which needs to be removed and replaced with a From<&str> impl.

@SimonSapin
Copy link
Member

We can add From<&str> easily enough, but removing FromStr is a breaking change. Going through each dependent to increment the version number requirement is more effort than removing a useless impl is worth. But we can do it next time there’s another breaking change.

@nox
Copy link
Contributor

nox commented Dec 6, 2018

Why should we remove FromStr?

@nikhilshagri
Copy link
Contributor Author

I don't remember exactly, but it might have been to make the code more idiomatic.

@brightly-salty
Copy link

I'd be willing to attempt to implement this and submit a PR. I can definitely add the From<&str> impl.
To me, FromStr is idiomatic enough. I see it commonly used in parsing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants