Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert in max_texture_size #1027

Closed
kvark opened this issue Mar 29, 2017 · 4 comments
Closed

Assert in max_texture_size #1027

kvark opened this issue Mar 29, 2017 · 4 comments
Labels
help wanted type: bug

Comments

@kvark
Copy link
Member

kvark commented Mar 29, 2017

See logs:
https://treeherder.mozilla.org/logviewer.html#?job_id=87300231&repo=try&lineNumber=3307
Related PR #1025 didn't fix it. Need to investigate.

cc @nical @staktrace
@staktrace
Copy link
Contributor

@nical It was definitely something in #1004 that caused this, I bisected the WR changes to isolate the regression. You can find a full try push showing the failures at https://treeherder.mozilla.org/#/jobs?repo=try&revision=07cca001d72d6fc9d90618016124203c1d4f5317

@nical
Copy link
Contributor

nical commented Mar 30, 2017

I am pretty sure this is happening because the image is an external buffer and I assumed we did not support tiling those (yet), so I disabled automatically tiling this type of images in that PR. Thankfully it's trivial to re-enable. I still think we don't properly tile external image buffers (as in the interface when later uploading the external buffer does not take tiling into account), we'll have to fix that as a followup.

@nical nical mentioned this issue Mar 30, 2017
Merged
bors-servo pushed a commit that referenced this issue Mar 30, 2017
Auto merge of #1036 - nical:tiled-external-buffer, r=kvark
8722163 
Tile external buffer images when they exceed the maximum texture size.

Fixes issue #1027, and addresses a review comment from PR #1004 about explicitly enumerating all variants instead of using ```_ => { ... }``` in this match expression.

r? @kvark

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1036)
<!-- Reviewable:end -->
@glennw
Copy link
Member

glennw commented Mar 31, 2017

This has merged.

@glennw glennw closed this as completed Mar 31, 2017
@staktrace
Copy link
Contributor

Fix verified in try push https://treeherder.mozilla.org/#/jobs?repo=try&revision=b96726c4cf97169672cc938067d1f0c97a09e40c

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kvark @nical @staktrace @glennw