Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the overscroll code #2545

Closed
paulrouget opened this issue Mar 20, 2018 · 0 comments
Closed

Remove the overscroll code #2545

paulrouget opened this issue Mar 20, 2018 · 0 comments

Comments

@paulrouget
Copy link
Contributor

By overscroll, I mean the bouncing effect when scrolling beyond the borders of the page in https://github.com/servo/webrender/blob/master/webrender/src/clip_scroll_node.rs

We are implementing this at the embedder level. For example, on Android, we will be using an OverScroller and draw the overscroll effect directly on top of Servo.
@paulrouget paulrouget mentioned this issue Mar 20, 2018
Closed
glennw pushed a commit to glennw/webrender that referenced this issue Apr 6, 2018
@gw3583
Remove overscroll code and api.
c262d18 
Fixes servo#2545.
Fixes servo#1762.
Fixes servo#1314.
@glennw glennw mentioned this issue Apr 6, 2018
Merged
bors-servo pushed a commit that referenced this issue Apr 6, 2018
Auto merge of #2629 - glennw:remove-overscroll, r=mrobinson
a05186d 
Remove overscroll code and api.

Fixes #2545.
Fixes #1762.
Fixes #1314.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2629)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulrouget