Remove overscroll code and api. #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes servo#2545. Fixes servo#1762. Fixes servo#1314.
|
This is better handled at a higher level by the embedder / client, as per #2545. I'm not sure if I removed too much - I wasn't quite sure if we still need the ScrollEventPhase? Long term, we should probably switch Servo to use the API that Gecko uses to scroll by a specific scroll node, and remove the other scroll API, I think? r? @mrobinson |
mrobinson
approved these changes
Apr 6, 2018
|
@bors-servo r+ |
|
📌 Commit c262d18 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Apr 6, 2018
Remove overscroll code and api. Fixes #2545. Fixes #1762. Fixes #1314. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2629) <!-- Reviewable:end -->
|
I wonder if we can also remove |
|
☀️ Test successful - status-appveyor, status-taskcluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2545.
Fixes #1762.
Fixes #1314.
This change is