-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple SVG primitives #402
Comments
Can I take this since #402 appears to depend on it? |
Yep! |
For now, it's probably best to just rely on Skia or Cairo to rasterize, stroke and dash the path geometry into a A8 texture that's uploaded to the GPU. In the future we can look at more sophisticated GPU techniques. FWIW, both of Direct2D's rasterization techniques seem like good options:
|
Sorry for not replying shortly. I'm taking medical therapy now and was not
able to send any message.
There is some kind of prototype but it's not working right for now. I guess
I was too optimistic and spent too much time trying to make GPU path
rasterization working.
As I'm not able to work on it right now, I guess it's a good idea to let
@kvark implement it.
…--------------------------------------------------
Александров Сергей Васильевич
2016-12-14 20:14 GMT+03:00 Josh Matthews <notifications@github.com>:
@splav <https://github.com/splav> Have you made progress on this? @kvark
<https://github.com/kvark> is interested in working on it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#402 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALHIryO4jb16WQNFig9-HQCzp3ey3qfks5rICQOgaJpZM4J8VzF>
.
|
Thanks for replying, and get well! :) |
We (as in - Quantum Rendering team) came up with a different API to provide SVG support: First preparations are already in flight - #852 |
I think it's probably still worth pursuing this approach. I think there's still value in having webrender understand the scene as much as possible. However, we'll likely use the vector image support in Gecko first. |
@askalski expressed interest and experience with rendering and SVG. Is there some way they could contribute to this effort? They've made a number of contributions to Servo proper in the past. |
Yes - we'd still like to have direct SVG support in WR eventually, so it could be fine to start working on that. It won't overlap / interfere with the current gecko plans, which is a good thing. |
well, to be honest I am a typical coder, not an architect. I leave the technical decisions to you guys, just show me the list I can pick tickets from :) |
Note: this is part of the NCSU SVG project; please don't work on this without talking with me first.
This task requires:
SVGGeometry
display item which represents a solid colored circleadd_geometry
andremove_geometry
APIs (analogous to the existingadd_image
andremove_image
APIs)get_glyph_dimensions
(ie. rasterize the geometry in parallel) (TODO)Code:
webrender_traits/src/api.rs
,webrender_traits/src/types.rs
@glennw If you can help fill out the details here, that would be great. I was basing this on servo/servo#12973 (comment)
The text was updated successfully, but these errors were encountered: