Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to not depend on offscreen_gl_context #1009

Merged
merged 1 commit into from Mar 28, 2017
Merged

Allow to not depend on offscreen_gl_context #1009

merged 1 commit into from Mar 28, 2017

Conversation

@sotaroikeda
Copy link
Contributor

sotaroikeda commented Mar 24, 2017 •
edited by larsbergstrom

It is created based on #773.

cc @emilio, @kvark, @glennw

This change is Reviewable
@sotaroikeda
Copy link
Contributor Author

sotaroikeda commented Mar 24, 2017

A priority became higher because of Bug 1349967[1]

[1]
https://bugzilla.mozilla.org/show_bug.cgi?id=1349967
@nical
Copy link
Collaborator

nical commented Mar 24, 2017

I would prefer it if instead of adding conditional compilation all over the code we would just contain that inside of WebGLContextWrapper (and have a WebGLContextWrapper with mostly empty functions if the webrender feature isn't enabled.
@kvark
kvark reviewed Mar 24, 2017
View changes
Copy link
Member

kvark left a comment

PR is OK. I do agree with @nical that we should explore the option to cut out less stuff by providing dummies/stubs.
webrender/src/record.rs Outdated
@@ -77,6 +78,19 @@ pub fn should_record_msg(msg: &ApiMsg) -> bool {
&ApiMsg::TickScrollingBounce |
&ApiMsg::WebGLCommand(..) =>

This comment has been minimized.

Sign in to view
@kvark

kvark Mar 24, 2017

Member

should just apply the cfg to this item only
@sotaroikeda sotaroikeda force-pushed the sotaroikeda:feat-webgl branch from 17a9571 to 0d5e019 Mar 27, 2017
@sotaroikeda
Allow to not depend on offscreen_gl_context
Loading status checks…
78af0cd
@sotaroikeda sotaroikeda force-pushed the sotaroikeda:feat-webgl branch from 0d5e019 to 78af0cd Mar 27, 2017
@sotaroikeda
Copy link
Contributor Author

sotaroikeda commented Mar 27, 2017

Updated a patch as to reduce cfg.
@sotaroikeda
Copy link
Contributor Author

sotaroikeda commented Mar 27, 2017

@kvark, can you review the pull request again?
@emilio
Copy link
Member

emilio commented Mar 27, 2017

I guess another alternative for this would be to depend on offscreen_gl_context, but without the x11 feature (which is enabled by default).

This would make it just use the not_implemented platform by default, which would mean that you wouldn't need any cfg at all I think.
@kvark
Copy link
Member

kvark commented Mar 27, 2017

Oh interesting, @emilio !
@sotaroikeda would you want to try that idea out? Should be simpler.
@sotaroikeda
Copy link
Contributor Author

sotaroikeda commented Mar 28, 2017 •
edited

It was my first proposal, but now I prefer current pull request's approach since it could make crate dependency of gecko simpler. The current approach could remove several crates from /third_party/rust of gecko.
@nical
Copy link
Collaborator

nical commented Mar 28, 2017

I like the idea of avoiding unnecessary dependencies in gecko's repository.
@emilio
Copy link
Member

emilio commented Mar 28, 2017

Sounds good, then this looks good to me, does anybody else have any concern with the current approach? If not, feel free to r=me.
@kvark
Copy link
Member

kvark commented Mar 28, 2017

Sounds like a consensus to me :)
@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Mar 28, 2017

📌 Commit 78af0cd has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Mar 28, 2017

⌛ Testing commit 78af0cd with merge 5c2a9ff...
bors-servo added a commit that referenced this pull request Mar 28, 2017
@bors-servo
Auto merge of #1009 - sotaroikeda:feat-webgl, r=emilio
Loading status checks…
5c2a9ff 
Allow to not depend on offscreen_gl_context

It is created based on #773.

cc @emilio, @kvark, @glennw

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1009)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 28, 2017

☀️ Test successful - status-travis
Approved by: emilio
Pushing 5c2a9ff to master...
@bors-servo bors-servo merged commit 78af0cd into servo:master Mar 28, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Mar 28, 2017
Merged
@sotaroikeda sotaroikeda deleted the sotaroikeda:feat-webgl branch Mar 30, 2017
moz-v2v-gh pushed a commit to mozilla/gecko-projects that referenced this pull request Mar 30, 2017
Sotaro Ikeda
Bug 1325298 - Remove static link to GL of webrender. r=kats
852cd92 
This is no longer needed after servo/webrender#1009

MozReview-Commit-ID: GEHGRK0TGXY
Manishearth pushed a commit to Manishearth/gecko-dev that referenced this pull request Apr 5, 2017
Sotaro Ikeda
Bug 1325298 - Remove static link to GL of webrender. r=kats
9340ba0 
This is no longer needed after servo/webrender#1009

MozReview-Commit-ID: GEHGRK0TGXY
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 1, 2019
@marco-c
Bug 1325298 - Remove static link to GL of webrender. r=kats
1ea79e3 
This is no longer needed after servo/webrender#1009

MozReview-Commit-ID: GEHGRK0TGXY

UltraBlame original commit: a5222d76fff2c8a7bda16baca390b795424e2fd2
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
@marco-c
Bug 1325298 - Remove static link to GL of webrender. r=kats
1bfb9e4 
This is no longer needed after servo/webrender#1009

MozReview-Commit-ID: GEHGRK0TGXY

UltraBlame original commit: a5222d76fff2c8a7bda16baca390b795424e2fd2
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
@marco-c
Bug 1325298 - Remove static link to GL of webrender. r=kats
5149a21 
This is no longer needed after servo/webrender#1009

MozReview-Commit-ID: GEHGRK0TGXY

UltraBlame original commit: a5222d76fff2c8a7bda16baca390b795424e2fd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@sotaroikeda @nical @emilio @kvark @bors-servo
You can’t perform that action at this time.