Add channel_index in ExternalImageHandler callback, ExternalImageData and UpdateForExternalBuffer #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I appreciate the cleanup, thank you! Please squash a bit to proceed. |
Also remove the release() interface in ExternalImageHandler. The external image life time checking could be replaced by comparing the epoch id of RenderNotifier. So, the release() interface is not necessary now.
… and UpdateForExternalBuffer.
In some video image formats(e.g. yuv or nv12), we could have more than one
channel data for that video image. Currently, we use different external image id
for each channel data. This patch add one additional channel_index data member
in ExternalImageData. Then, we could use this channel_index to select the
specific channel data with the same ExternalImageId.
Example:
Add 2 chanel image into WR.
api.add_image(...
ImageData::External(ExternalImageData {
id: ExternalImageId(external_image_id),
channel_index: 0,
...
}),
...);
api.add_image(...
ImageData::External(ExternalImageData {
id: ExternalImageId(external_image_id),
channel_index: 1,
...
}),
...);
JerryShih
force-pushed
the
ext-image-with-channel-index-pull-request
branch
from
95f0e56
to
d733af2
Compare
|
@kvark |
|Cargo update webrender| webrender 0.34.0
|
Thank you! |
|
📌 Commit 3ae6235 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Apr 18, 2017
…uest, r=kvark Add channel_index in ExternalImageHandler callback, ExternalImageData and UpdateForExternalBuffer <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1125) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
bors-servo
pushed a commit
that referenced
this pull request
Apr 18, 2017
… r=kvark Add GL_TEXTURE_EXTERNAL_OES texture target @kvark @glennw r? Please only review the patch "Add TextureExternalHandle in ExternalImageType and External in TextureTarget". The remaining patches will be handled at #1125 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1132) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is