Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add channel_index in ExternalImageHandler callback, ExternalImageData and UpdateForExternalBuffer #1125

Merged
merged 3 commits into from
Apr 18, 2017
Merged

Add channel_index in ExternalImageHandler callback, ExternalImageData and UpdateForExternalBuffer #1125

merged 3 commits into from
Apr 18, 2017

Commits on Apr 18, 2017

  1. Remove the pending deletion of external image. 

    Also remove the release() interface in ExternalImageHandler.
The external image life time checking could be replaced by comparing the epoch
id of RenderNotifier. So, the release() interface is not necessary now.
    @JerryShih
    JerryShih committed Apr 18, 2017
    Configuration menu
    Copy the full SHA
    86d4255 View commit details
    Browse the repository at this point in the history

  2. Add channel_index in ExternalImageHandler callback, ExternalImageData… 

    … and UpdateForExternalBuffer.

In some video image formats(e.g. yuv or nv12), we could have more than one
channel data for that video image. Currently, we use different external image id
for each channel data. This patch add one additional channel_index data member
in ExternalImageData. Then, we could use this channel_index to select the
specific channel data with the same ExternalImageId.

Example:
Add 2 chanel image into WR.
api.add_image(...
              ImageData::External(ExternalImageData {
                                    id: ExternalImageId(external_image_id),
                                    channel_index: 0,
                                    ...
                                  }),
              ...);
api.add_image(...
              ImageData::External(ExternalImageData {
                                    id: ExternalImageId(external_image_id),
                                    channel_index: 1,
                                    ...
                                  }),
              ...);
    @JerryShih
    JerryShih committed Apr 18, 2017
    Configuration menu
    Copy the full SHA
    d733af2 View commit details
    Browse the repository at this point in the history

  3. Cargo.toml updating. 

    |Cargo update webrender|
webrender 0.34.0
    @JerryShih
    JerryShih committed Apr 18, 2017
    Configuration menu
    Copy the full SHA
    3ae6235 View commit details
    Browse the repository at this point in the history