Check the aa_range before calculating the ellipse distance. #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll have a gecko try later. |
|
gecko try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a |
|
Thanks! @bors-servo r+ |
|
📌 Commit dcad8be has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 5, 2017
Check the aa_range before calculating the ellipse distance. We always put the ellipse distance to distance_aa. We can avoid some unnecessary calculations if we precheck the distance with aa_range. It also helps gecko [bug 1414575](https://bugzilla.mozilla.org/show_bug.cgi?id=1414575) 2ms on my device. For the large-boxshadow-ellipse-2.yaml, without the patch, I got: { "name": "benchmarks/large-boxshadow-ellipse-2.yaml", "backend_time_ns": 67797, "composite_time_ns": 7240335, "paint_time_ns": 5583450, "draw_calls": 5 }, with the patch: { "name": "benchmarks/large-boxshadow-ellipse-2.yaml", "backend_time_ns": 63598, "composite_time_ns": 4920898, "paint_time_ns": 4163536, "draw_calls": 5 }, <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2158) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always put the ellipse distance to distance_aa. We can avoid some unnecessary calculations if we precheck the distance with aa_range. It also helps gecko bug 1414575 2ms on my device. For the large-boxshadow-ellipse-2.yaml, without the patch, I got:
with the patch:
This change is