Ensure scene-only transactions still go through the scene builder thread #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead. If WR gets a transaction which only contains scene messages, and has the flag to use the scene builder thread, it will not actually use the scene builder thread, because the update_document function first drains all the scene messages, and then checks to see if the transaction is empty. In this scenario the transaction is empty (because all the scene messages got drained) but the op.build flag is set to true. So instead of delegating the scene build to the builder thread, the build is done on the RB thread. This patch modifies the condition so that all transactions that are intended to be handled by the scene builder thread get handled there.
|
r? @nical |
|
@bors-servo r+ |
|
📌 Commit 312b17e has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Apr 4, 2018
Ensure scene-only transactions still go through the scene builder thread If WR gets a transaction which only contains scene messages, and has the flag to use the scene builder thread, it will not actually use the scene builder thread, because the update_document function first drains all the scene messages, and then checks to see if the transaction is empty. In this scenario the transaction is empty (because all the scene messages got drained) but the op.build flag is set to true. So instead of delegating the scene build to the builder thread, the build is done on the RB thread. This patch modifies the condition so that all transactions that are intended to be handled by the scene builder thread get handled there. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2611) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If WR gets a transaction which only contains scene messages, and has the
flag to use the scene builder thread, it will not actually use the scene
builder thread, because the update_document function first drains all
the scene messages, and then checks to see if the transaction is empty.
In this scenario the transaction is empty (because all the scene
messages got drained) but the op.build flag is set to true. So instead
of delegating the scene build to the builder thread, the build is done
on the RB thread.
This patch modifies the condition so that all transactions that are
intended to be handled by the scene builder thread get handled there.
This change is