Add a sampler mechanism #2654
Merged
Add a sampler mechanism #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo r+ |
|
📌 Commit da5545a has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Apr 16, 2018
Add a sampler mechanism These changes are needed for https://bugzilla.mozilla.org/show_bug.cgi?id=1451469 r? @nical I wasn't totally sure what the best place was to hook in the sample() method in the first patch. Part of me was thinking it would be better to do it inside the `if op.render {...}` block but I think what I have is equivalent, at least for the gecko case, because all the transactions that have messages that produce `DocumentOps::render` will also have their `generate_frame` flag set. But let me know if you think that can be improved. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2654) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are needed for https://bugzilla.mozilla.org/show_bug.cgi?id=1451469
r? @nical
I wasn't totally sure what the best place was to hook in the sample() method in the first patch. Part of me was thinking it would be better to do it inside the
if op.render {...}block but I think what I have is equivalent, at least for the gecko case, because all the transactions that have messages that produceDocumentOps::renderwill also have theirgenerate_frameflag set. But let me know if you think that can be improved.This change is