-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement nine patch support for border gradients #2848
Conversation
r? @gw3583 |
This doesn't allow us to turn on WebRender border-image in Gecko yet, but gets us a little closer. We would need to investigate a bit more into why so many reference tests still fail. |
Reviewed 11 of 11 files at r1. webrender_api/src/display_item.rs, line 276 at r1 (raw file):
We can remove this comment now. Comments from Reviewable |
One minor nit above, r=me otherwise. It also looks like there is no edge AA between gradient stops in the radial gradient image, but I think that's just a pre-existing issue with the radial gradient shader. |
This will allow border-gradients to support the full richness of the CSS API. There are some areas where the implementation doesn't match what CSS expects, but this should move us a good deal closer. We can gradually fix those issues and turn this on in Gecko. Fixes servo#1875.
0e73f3f
to
54e8c80
Compare
@bors-servo r=gw3583 @gw3583 Thanks for the review! |
📌 Commit 54e8c80 has been approved by |
Implement nine patch support for border gradients This will allow border-gradients to support the full richness of the CSS API. There are some areas where the implementation doesn't match what CSS expects, but this should move us a good deal closer. We can gradually fix those issues and turn this on in Gecko. Fixes #1875. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2848) <!-- Reviewable:end -->
☀️ Test successful - status-appveyor, status-taskcluster |
For the purposes of not breaking the build, here's a Gecko try job (should not change behavior at all) for this change: https://treeherder.mozilla.org/#/jobs?repo=try&revision=76b9810cacc13df3dc227b73026f49775815317e&selectedJob=185117848 |
This will allow border-gradients to support the full richness of the CSS
API. There are some areas where the implementation doesn't match what
CSS expects, but this should move us a good deal closer. We can
gradually fix those issues and turn this on in Gecko.
Fixes #1875.
This change is