Intersect the update rect with each tile's dirty rect when updating an image. #3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n image. Otherwise each tile gets a dirty rect even if the tile isn't affected. This confuses the logic that requests/upload tiles.
|
r? @aosmond |
aosmond
reviewed
Sep 20, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
|
Try run looks good. @bors-servo r=aosmond |
|
📌 Commit 2dee3e1 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Sep 20, 2018
Intersect the update rect with each tile's dirty rect when updating an image. Otherwise each tile gets a dirty rect even if the tile isn't affected. This confuses the logic that requests/upload tiles. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3095) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise each tile gets a dirty rect even if the tile isn't affected. This confuses the logic that requests/upload tiles.
This change is