Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PictureId and PictureIdGenerator. #3288

Merged
merged 1 commit into from Nov 10, 2018

Conversation

@gw3583
Copy link
Collaborator

commented Nov 8, 2018

They are no longer required since we are comparing the content
of pictures when choosing to cache them.


This change is Reviewable

They are no longer required since we are comparing the content
of pictures when choosing to cache them.
@gw3583

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 8, 2018

r? anyone

@gw3583 gw3583 requested a review from kvark Nov 8, 2018
@kvark

This comment has been minimized.

Copy link
Member

commented Nov 9, 2018

D'oh, it's the second time we are removing those! I barely got used to having them :)

@kvark

This comment has been minimized.

Copy link
Member

commented Nov 9, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2018

📌 Commit 755832f has been approved by kvark

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2018

⌛️ Testing commit 755832f with merge 2fb334c...

bors-servo added a commit that referenced this pull request Nov 9, 2018
Remove PictureId and PictureIdGenerator.

They are no longer required since we are comparing the content
of pictures when choosing to cache them.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3288)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2018

💔 Test failed - status-appveyor

@gw3583

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 9, 2018

@bors-servo retry

@jdm

This comment has been minimized.

Copy link
Member

commented Nov 9, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2018

⌛️ Testing commit 755832f with merge 2ac128b...

bors-servo added a commit that referenced this pull request Nov 9, 2018
Remove PictureId and PictureIdGenerator.

They are no longer required since we are comparing the content
of pictures when choosing to cache them.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3288)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2018

⌛️ Testing commit 755832f with merge 1adb352...

bors-servo added a commit that referenced this pull request Nov 9, 2018
Remove PictureId and PictureIdGenerator.

They are no longer required since we are comparing the content
of pictures when choosing to cache them.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3288)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 10, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing 1adb352 to master...

@bors-servo bors-servo merged commit 755832f into servo:master Nov 10, 2018
2 of 3 checks passed
2 of 3 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.