Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RectangleKey for hashing float rects. #3348

Merged
merged 1 commit into from
Nov 25, 2018
Merged

Add RectangleKey for hashing float rects. #3348

merged 1 commit into from
Nov 25, 2018

Commits on Nov 25, 2018

  1. Add RectangleKey for hashing float rects. 

    The Au <-> f32 conversion is showing up in a lot of talos profiles.

Since layout in both Gecko and Servo already operate on Au, the
values are already quantized, and so it's reasonable to just
directly hash the floats and avoid the conversions.

This patch changes the main rectangles in PrimitiveKey to be
directly hashed. We can incrementally convert other fields in
the PrimitiveKeyKind to also hash the data types directly.

On Talos, this takes the dl_mutate time from ~4780 down to ~4600
which is a decent win.
    @gw3583
    gw3583 committed Nov 25, 2018
    Configuration menu
    Copy the full SHA
    1f81acb View commit details
    Browse the repository at this point in the history