picture: Only collect clip nodes for raster roots, not all surfaces. #3480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is effectively a revert of 47242e1. The assumption that patch introduces does just not hold for fixed-pos clips, unless we introduce more complexity to turn them into their own spatial nodes of course. Per https://bugzilla.mozilla.org/show_bug.cgi?id=1501111#c11 this is no longer needed for picture caching, so let's use the clip node collectors when the assumption they use hold (which is when the picture is a raster root, since raster roots are reference frames, and reference frames are a containing block for fixed-pos elements). This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1501111.
|
The try run seems to be missing some of the usual configs? But maybe they are not relevant in this case? The change looks good to me. |
gw3583
approved these changes
Jan 7, 2019
|
@bors-servo r=gw3583 |
|
📌 Commit eeabfae has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jan 7, 2019
picture: Only collect clip nodes for raster roots, not all surfaces. This is effectively a revert of 47242e1. The assumption that patch introduces does just not hold for fixed-pos clips, unless we introduce more complexity to turn them into their own spatial nodes of course. Per https://bugzilla.mozilla.org/show_bug.cgi?id=1501111#c11 this is no longer needed for picture caching, so let's use the clip node collectors when the assumption they use hold (which is when the picture is a raster root, since raster roots are reference frames, and reference frames are a containing block for fixed-pos elements). This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1501111. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3480) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 8, 2019
…f10d26aef892 (WR PR #3480). r=kats servo/webrender#3480 Differential Revision: https://phabricator.services.mozilla.com/D15893 --HG-- extra : moz-landing-system : lando
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Jan 8, 2019
…f10d26aef892 (WR PR #3480). r=kats servo/webrender#3480 Differential Revision: https://phabricator.services.mozilla.com/D15893
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…f10d26aef892 (WR PR #3480). r=kats servo/webrender#3480 Differential Revision: https://phabricator.services.mozilla.com/D15893 UltraBlame original commit: d77ee4b960ad795291b03507d9b0edb30f77d6eb
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…f10d26aef892 (WR PR #3480). r=kats servo/webrender#3480 Differential Revision: https://phabricator.services.mozilla.com/D15893 UltraBlame original commit: d77ee4b960ad795291b03507d9b0edb30f77d6eb
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…f10d26aef892 (WR PR #3480). r=kats servo/webrender#3480 Differential Revision: https://phabricator.services.mozilla.com/D15893 UltraBlame original commit: d77ee4b960ad795291b03507d9b0edb30f77d6eb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is effectively a revert of 47242e1.
The assumption that patch introduces does just not hold for fixed-pos clips,
unless we introduce more complexity to turn them into their own spatial nodes of
course.
Per https://bugzilla.mozilla.org/show_bug.cgi?id=1501111#c11 this is no longer
needed for picture caching, so let's use the clip node collectors when the
assumption they use hold (which is when the picture is a raster root, since
raster roots are reference frames, and reference frames are a containing block
for fixed-pos elements).
This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1501111.
This change is