Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow setting near/far planes and listening for view update events #41
Conversation
|
OK, a minor nit about keeping a dirty bit in the clip info, since most of the structs in |
webxr-api/view.rs
Outdated
| pub near: f32, | ||
| pub far: f32, | ||
| /// Was there an update that needs propagation to the client? | ||
| update: bool, |
This comment has been minimized.
This comment has been minimized.
asajeffrey
Aug 21, 2019
Member
Hmm, it would be nice if we didn't have to keep a dirty bit on the ClipPlanes itself.
Manishearth
force-pushed the
Manishearth:wherever-you-are
branch
from
8feca87
to
3e6486e
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 21, 2019
Allow setting near/far planes and listening for view update events r? @asajeffrey I couldn't handle magicleap, sadly, since I can't get it to build, and it seems to manage its own projection matrices Fixes #32
|
|
|
Manishearth
force-pushed the
Manishearth:wherever-you-are
branch
from
3e6486e
to
e77822c
|
@bors-servo r=asajeffrey |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 22, 2019
Allow setting near/far planes and listening for view update events r? @asajeffrey I couldn't handle magicleap, sadly, since I can't get it to build, and it seems to manage its own projection matrices Fixes #32
|
|
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Aug 23, 2019
Allow setting near/far clip planes needs servo/webxr#41 r? @asajeffrey <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24018) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Aug 23, 2019
Allow setting near/far clip planes needs servo/webxr#41 r? @asajeffrey <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24018) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedAug 20, 2019
•
edited
r? @asajeffrey
I couldn't handle magicleap, sadly, since I can't get it to build, and it seems to manage its own projection matrices
Fixes #32