-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
navigation spacing is not consistent #38
Comments
Yeah, I agree with you, the nav bar isn't looking so hot any more. The even-width nav headers is a hold-over from when there was a lot less in the header. There used to be a lot more white space between the individual links in the nav bar and it looked good. Then we added a bunch of social media and some more links to parts of the website and it's become pretty crowded. We have been meaning to update the nav bar to something that works and looks nicer. PR's are always appreciated if you have a good idea how we can fix this. |
Tucker, make a PR and I'll test it at various resolutions to make sure it looks good for all. |
Alright |
@mtuck063 looks great to me. I'd also consider finding uniform icons for Twitter/Facebook/Instagram/Mail. It helps build a consistent design language but maybe I should open another issue for that. |
Define what you mean by "uniform icons" in this case. |
The main navigation (in full desktop view) has inconsistent spacing. For example, the item "SESA" has significantly more padding/margins than a larger item such as "First Year Tips". I understand this is because a fixed width is being used for all tabs, however I think there is merit in maintaining spacing even if the sizing of the nav buttons would differ. This seems to be a pretty commonly accepted standard and most websites with similar navigation functions seem to maintain spacing.
For an example implementation, check out my website: https://vedpetkar.com or Bootstrap's project website: http://getbootstrap.com/.
The text was updated successfully, but these errors were encountered: