Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dawn library #8

Open
sessamekesh opened this issue Jan 24, 2022 · 3 comments
Open

Update Dawn library #8

sessamekesh opened this issue Jan 24, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@sessamekesh
Copy link
Owner

Looks like another warning has snuck in - the WGSL language has changed again, and is replacing [[decoration]] style blocks with @decoration style annotations.

@sessamekesh sessamekesh added this to the MVP renderer implemented milestone Jan 24, 2022
@sessamekesh sessamekesh added the bug Something isn't working label Jan 24, 2022
@sessamekesh
Copy link
Owner Author

Updated in c237db5

But... guess what? It's time to update again! This time the API for specifying load/store ops against framebuffers on render pass creation has changed.... so you need to update again 🙃

@sessamekesh
Copy link
Owner Author

Looks like part of the API has become deprecated: RenderPassEncoder EndPass method is now End.

This is not reflected in the Emscripten WebGPU bindings yet - https://github.com/emscripten-core/emscripten/blob/a02b254dfedce9c8a26b9bc3f9a11561f9adeb58/system/include/webgpu/webgpu_cpp.h#L893

This change is breaking in Chromium - https://source.chromium.org/chromium/chromium/src/+/main:out/Debug/gen/third_party/dawn/emscripten-bits/webgpu_cpp.h;l=935;drc=0366351bbd562c89684c861a1c8be1eb84e0f42e

This might be okay for now, but at some point the build will be broken.

Open an issue up with Emscripten to discuss possible resolution of the issue.

@sessamekesh
Copy link
Owner Author

Also (and this is really weird) - the master up-to-date Dawn build is not giving the same errors the Chromium build is giving - my guess is there's a flag in there somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant