Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility with Unity #91

Closed
christougher opened this issue Dec 9, 2019 · 7 comments
Closed

compatibility with Unity #91

christougher opened this issue Dec 9, 2019 · 7 comments
Labels
enhancement New feature or request

Comments

@christougher
Copy link

Description

When Importing C5 into Unity 2019.3 a whole slew of errors occur. I've seen references that c5 is/was actually compatible with Unity and I even have access to an older c5.dll that works, but was hoping to get this into Unity

Solution

Version of c5 that is able to be integrated into Unity

@christougher christougher added the enhancement New feature or request label Dec 9, 2019
@ondfisk
Copy link
Collaborator

ondfisk commented Dec 15, 2019

Can you provide some more context. Are you using the latest 3.0-beta?
No one on the team has any skills in Unity. Can you share a sample project which shows the issue?

@christougher
Copy link
Author

actually I used an older version and it works fine. Thanks. I believe it stopped being compatible in February when:

  • Retarget to .NET Standard 2.0 only

@ondfisk
Copy link
Collaborator

ondfisk commented Dec 15, 2019

According to this: https://docs.microsoft.com/en-us/dotnet/standard/net-standard, Unity should be fine with .NET Standard 2.0.

@Ryan-M3
Copy link

Ryan-M3 commented Feb 15, 2020

I can confirm that C5 throws "999+" errors, at that changing to a commit vaguely around February fixes it. To reproduce: download Unity; start a new project; clone C5 into Assets folder; wait for Unity to automatically compile; check in-engine console for errors. I'm not proficient enough in C# to comment on the why.

@ondfisk
Copy link
Collaborator

ondfisk commented Feb 15, 2020

@Ryan-M3 dumping the .cs files directly in Unity will not work as C5 compiles using C# 8.0.
It is targetting .NET Standard 2.0 which Unity supports.
Can you get the NuGet package instead?
I read somewhere that you could use https://github.com/GlitchEnzo/NuGetForUnity and then use https://www.nuget.org/packages/C5/3.0.0-beta

@Ryan-M3
Copy link

Ryan-M3 commented Feb 16, 2020

@Ryan-M3 dumping the .cs files directly in Unity will not work as C5 compiles using C# 8.0.
It is targetting .NET Standard 2.0 which Unity supports.
Can you get the NuGet package instead?
I read somewhere that you could use https://github.com/GlitchEnzo/NuGetForUnity and then use https://www.nuget.org/packages/C5/3.0.0-beta

Worked like a charm. The only gotcha was that I had to make sure I clicked "include pre-release" in order to get the exact version you specified. Using an older version led me to waste a little time troubleshooting my own error. :)

@ondfisk
Copy link
Collaborator

ondfisk commented Feb 16, 2020

Great.
Will close the issue then.
We will hopefully be able to release a 3.0 version without pre very soon.

@ondfisk ondfisk closed this as completed Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants