Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid doc block type hint for SetFont $size #29

Open
MaximilianKresse opened this issue Mar 6, 2024 · 0 comments
Open

Invalid doc block type hint for SetFont $size #29

MaximilianKresse opened this issue Mar 6, 2024 · 0 comments

Comments

@MaximilianKresse
Copy link
Member

The current doc block for the $size param of \setasign\SetaFpdf\SetaFpdf::SetFont() is:

@param string $size Font size in points. The default value is the current size. If no size has been specified 
                    since the beginning of the document, the value taken is 12.

Which calls internally \setasign\SetaFpdf\Modules\Font::set() which has the following doc block for $size:

@param string $size

But the size will be written into \setasign\SetaFpdf\StateBuffer\Font::$currentFontSize (without casting) which expects int|float.

The default of Fpdf for this method is also the integer 0 and not an empty string. This should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant