Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug , always select the highers value #5

Closed
sam12github opened this issue Apr 3, 2013 · 3 comments
Closed

bug , always select the highers value #5

sam12github opened this issue Apr 3, 2013 · 3 comments
Assignees

Comments

@sam12github
Copy link

[V2, 0.0016]
 |- 0 ≤ x < 49.5
 |  [V1, 0.0000]
 |   |- 1 ≤ x < 1.01
 |   |   +(L, 1)-----------------------------<<<< this supposed to be "s" 
 |- 49.5 ≤ x < 99.01
 |   +(L, 1)



    [Test]
    public void ValueObject_Test_With_Yield_Enumerator()
    {
        var data = ValueObject.GetData();
        var generator = new DecisionTreeGenerator()
        {
            Descriptor = Descriptor.Create<ValueObject>()
        };

        var decisionTree = new DecisionTreeGenerator();
        var model = generator.Generate(data);

        var o = new ValueObject() { V1 = 1, V2 =10 };
        var os = model.Predict<ValueObject>(o).R;
        Assert.AreEqual("l".Sanitize(), os);
    }
@ghost ghost assigned sethjuarez Apr 5, 2013
@sethjuarez
Copy link
Owner

I will take a look at this soon. Thanks for the heads-up.

---UPDATE
In this case the test reflected V2's as 0 - 999. If that was the case, then the answer was indeed correctly generated as the split values when computing information gain in the continuous case does not take into account the data but simply uses the maximum likelihood estimates for splitting (i.e. x < mean <= x). I should add more smarts to this part.

@sam12github
Copy link
Author

the analyzing was correct and acureate , 0 to 50 = s (small ) , and 0 to 100 "l" large , so the program guessed the equation , but for some reason it put in the both places "l"
and I found in other scenarios some thing , in other example always was taking "very-good" label which was the highest one

@sethjuarez
Copy link
Owner

Interesting... Have you tried the latest bits? If something is off I want to make sure to fix it as soon as possible. Thanks again my friend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants