Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature for setting and saving a default theme for the editor. #81

Closed
SethWalkeroo opened this issue Oct 14, 2020 · 8 comments
Closed
Assignees
Labels
enhancement New feature or request Hacktoberfest

Comments

@SethWalkeroo
Copy link
Owner

There is a default theme already in the theme configs, but it never changes. It would be cool if the user didn't have to reset their theme every time they reloaded the editor.

@SethWalkeroo SethWalkeroo added enhancement New feature or request Hacktoberfest labels Oct 14, 2020
@zer0link
Copy link

Hi, this seems like an interesting issue, can you please assign to me so I work on that?

@SethWalkeroo
Copy link
Owner Author

@zer0link for sure, message me if you have any difficulties. The feature is brand new and I haven't fully thought out how it will be continually integrated.

@zer0link
Copy link

Thanks for the assignment, @SethWalkeroo ,
I tried to run the steps in readme, and I played around with the color schemes and restarting the editor a couple of times. It seems to remember the last color scheme I am using.
Maybe I misunderstood the issue here, can you show me a step by step to reproduce the issue?

@SethWalkeroo
Copy link
Owner Author

@zer0link Oh, looks like there is a problem with loading the default theme. If you open up the editor again and try entering some syntax, you will notice that the syntax is in the theme of Gruvbox, which is the default theme at the moment. I forgot to initialize the rest of the theme, I will work on that now.

@SethWalkeroo
Copy link
Owner Author

@zer0link Alright, the default theme should load up the same every time you launch the editor now.

@zer0link
Copy link

Yes, I can see everytime I restarted the editor, it uses the default theme (Gruvbox)

@zer0link
Copy link

Hi, can I know if the issue is still open?

@SethWalkeroo
Copy link
Owner Author

@zer0link No, sorry, this issue is now closed. I've added the default theme setting to the editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants