Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple puma_bind #42

Closed
masterkain opened this issue Mar 30, 2014 · 9 comments
Closed

multiple puma_bind #42

masterkain opened this issue Mar 30, 2014 · 9 comments

Comments

@masterkain
Copy link
Contributor

I have two binds for puma:

bind 'tcp://0.0.0.0:9220'
bind 'unix:///tmp/unicorn.sock'

Would it possible to support them both via set :puma_bind? Perhaps supporting an array option.

@seuros
Copy link
Owner

seuros commented Mar 30, 2014

Just bundle update to use version 0.4.0

@seuros
Copy link
Owner

seuros commented Mar 30, 2014

just set puma_bind as an array and regenerate the file with puma:config

  set :puma_bind , %['tcp://0.0.0.0:9220' 'unix:///tmp/puma.sock' ]

@masterkain
Copy link
Contributor Author

Thanks, good work 👍

@masterkain
Copy link
Contributor Author

However I see a problem with this, the resulting template is missing quotation marks

bind unix:///tmp/unicorn.sock # should be 'unix:///tmp/unicorn.sock'
bind tcp://0.0.0.0:9220 # should be 'tcp://0.0.0.0:9220'

and it's raising error on puma startup.

@seuros
Copy link
Owner

seuros commented Mar 30, 2014

I fixed that in the last commit.
I was using %['tcp://0.0.0.0:9220' 'unix:///tmp/puma.sock' ] instead of ['tcp://0.0.0.0:9220', 'unix:///tmp/puma.sock' ] so the quotation were copied.

@seuros seuros reopened this Mar 30, 2014
@masterkain
Copy link
Contributor Author

The result now is

'bind unix:///tmp/unicorn.sock'
'bind tcp://0.0.0.0:9220'

the quote should go after bind :)

@masterkain
Copy link
Contributor Author

Oh I see the other commit, thanks!

@seuros
Copy link
Owner

seuros commented Mar 30, 2014

you can use the version in rubygems if you want.

@masterkain
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants