-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CustomDeclarationOrderCheck: Correct spelling of DeclareAnonClassField #656
Labels
Milestone
Comments
@jsoref This doesn't explain anything like name of check being affected and why it is being renamed. |
jsoref
added a commit
to jsoref/sevntu.checkstyle
that referenced
this issue
Apr 3, 2018
romani
changed the title
Correct spelling of DeclareAnonClassField
CustomDeclarationOrderCheck: Correct spelling of DeclareAnonClassField
Apr 4, 2018
@jsoref, please explain users how to migrate, what they should change in theirs config file. In your commit you have example, just place it to description |
I added migration section. |
jsoref
added a commit
to jsoref/sevntu.checkstyle
that referenced
this issue
Apr 4, 2018
…lling of DeclareAnonClassField
romani
pushed a commit
that referenced
this issue
Apr 6, 2018
fix is merged |
kariem
pushed a commit
to kariem/sevntu.checkstyle
that referenced
this issue
Jul 26, 2018
…lling of DeclareAnonClassField
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To date, the annotation is
DeclareAnnonClassField(...)
, but conceptually, it's trying to describe "declare an anonymous class field", the proper abbreviation for anonymous should be anon, not annon (which would be an abbreviation forannonymous
[sic]), and thus the correct annotation should beDeclareAnonClassField(...)
.Migration for users
If you use
DeclareAnnonClassField
in your configuration for this Check, please rename it toDeclareAnonClassField
.The text was updated successfully, but these errors were encountered: