Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump-cs-version missed eclipsecs-sevntu-plugin #936

Closed
rnveach opened this issue Nov 11, 2022 · 3 comments · Fixed by #939
Closed

bump-cs-version missed eclipsecs-sevntu-plugin #936

rnveach opened this issue Nov 11, 2022 · 3 comments · Fixed by #939

Comments

@rnveach
Copy link
Contributor

rnveach commented Nov 11, 2022

Identified at
https://github.com/sevntu-checkstyle/sevntu.checkstyle/blob/master/eclipsecs-sevntu-plugin/pom.xml#L31
from commit 3fd8268

This was a new addition at 220bf2a due to a reported bug and was missed being added to bump-cs-version before its next run which resulted in the missed change at location mentioned above.

The main point of this issue is to expand bump-cs-version.yml for the new area to bump the checkstyle version when the YML is run. The above POM can also be updated as part of this issue in a separate commit.

https://github.com/sevntu-checkstyle/sevntu.checkstyle/blob/master/.github/workflows/bump-cs-version.yml

@rnveach
Copy link
Contributor Author

rnveach commented Nov 11, 2022

@romani If you agree, I think @stoyanK7 can work on this as part of the project

@romani
Copy link
Member

romani commented Nov 11, 2022

Issue is created checkstyle/contribution#694

@romani
Copy link
Member

romani commented Nov 26, 2022

Fix is merged

romani added a commit that referenced this issue Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants