Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail Fast for Certain Errors #147

Open
mariotaku opened this issue Mar 12, 2024 · 0 comments
Open

Fail Fast for Certain Errors #147

mariotaku opened this issue Mar 12, 2024 · 0 comments

Comments

@mariotaku
Copy link

Hi! I implemented a SSH connection pool in my project, and noticed when the connection can't be created (no route to host, failed to authenticate etc), get_timeout will actually retry until timeout.

I'd like to have an option to allow fail-fast for such case. In my fork, I added can_retry function in HandleError, and when it returns false, it will fail immediately without retry.

6ab3302...aaa2a2b

Do you think this feature makes sense? If so, I'll create a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant