Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated setVarsFromConfig() #32

Open
vidhiJain opened this issue Jun 22, 2017 · 1 comment
Open

Duplicated setVarsFromConfig() #32

vidhiJain opened this issue Jun 22, 2017 · 1 comment
Milestone
Fix Contingency T...

Comments

@vidhiJain
Copy link
Contributor

setVarsFromConfig() has been duplicated and has different interpretation in the following:

  • MakeSetup.java
  • BayesBaseCT_SortMerge.java
    • setVarsFromConfig()
    • setVarsFromConfigForTarget() ->?? Changes the existing variable databaseName_stdto a new meaning
  • FunctorWrapper.java
  • and many more ...

[Suggestion] : We need to set these as final variables during a single run.
@oschulte oschulte mentioned this issue Jun 23, 2017
Closed
@vidhiJain
Copy link
Contributor Author

Current implementation just populates only those variables from config.cfg that are required in the class. These variables are static. This enables independent execution of each class.
This can be replaced by executing setVarsFromConfig() method Config.java and using access (getter) methods of this class in every java class that requires these variables.

@rmar3a rmar3a mentioned this issue Feb 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Fix Contingency Table Generator
Development

No branches or pull requests
2 participants
@vidhiJain @oschulte