fix(eda.plot_missing & eda.plot_correlation): based on the comments proposed by the lab members #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waterpine
changed the title
Waterpine
changed the title
dovahcrow
force-pushed
the
plot_corr2
branch
2 times, most recently
from
b5429fd
to
74fd22b
Compare
jinglinpeng
reviewed
Sep 26, 2019
| inc_point_y.append(data_y[max_idx_inc]) | ||
| dec_point_x.append(data_x[max_idx_dec]) | ||
| dec_point_y.append(data_y[max_idx_dec]) | ||
| for i in range(len(data_x)): |
There was a problem hiding this comment.
The copy of the data could be avoided by incrementally computing Pearson correlation coefficient. This can be done in the next pr.
| fig = _vis_correlation_pd_x_y_k( | ||
| intermediate=intermediate, | ||
| params=params | ||
| pd_data_frame=pd_data_frame, x_name=x_name, y_name=y_name, k=k |
There was a problem hiding this comment.
Whether the style is better than previous version? (also for other style change in this file)
jinglinpeng
reviewed
Sep 26, 2019
| tooltips = [("x", "@x"), ("y", "@y"), ("z", "@z")] | ||
| hover = HoverTool(tooltips=tooltips) | ||
| if not data_p or not data_k or not data_s: | ||
| raise Warning("The result is empty") |
There was a problem hiding this comment.
Just show warning message, do not raise.
dovahcrow
changed the title
dovahcrow
force-pushed
the
plot_corr2
branch
7 times, most recently
from
ce6c0e7
to
a1aff9e
Compare
dovahcrow
force-pushed
the
plot_corr2
branch
from
a1aff9e
to
6fe9b99
Compare
dovahcrow
approved these changes
Sep 28, 2019
dovahcrow
added a commit
that referenced
this pull request
May 29, 2020
fix(eda.plot_missing & eda.plot_correlation): based on the comments proposed by the lab members
devinllu
pushed a commit
to devinllu/dataprep
that referenced
this pull request
Nov 9, 2021
fix(eda.plot_missing & eda.plot_correlation): based on the comments proposed by the lab members
fatbuddy
added a commit
to fatbuddy/dataprep
that referenced
this pull request
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: