-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eda.plot_missing & eda.plot_correlation): based on the comments proposed by the lab members #15
Conversation
b5429fd
to
74fd22b
Compare
inc_point_y.append(data_y[max_idx_inc]) | ||
dec_point_x.append(data_x[max_idx_dec]) | ||
dec_point_y.append(data_y[max_idx_dec]) | ||
for i in range(len(data_x)): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copy of the data could be avoided by incrementally computing Pearson correlation coefficient. This can be done in the next pr.
fig = _vis_correlation_pd_x_y_k( | ||
intermediate=intermediate, | ||
params=params | ||
pd_data_frame=pd_data_frame, x_name=x_name, y_name=y_name, k=k |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whether the style is better than previous version? (also for other style change in this file)
tooltips = [("x", "@x"), ("y", "@y"), ("z", "@z")] | ||
hover = HoverTool(tooltips=tooltips) | ||
if not data_p or not data_k or not data_s: | ||
raise Warning("The result is empty") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just show warning message, do not raise.
ce6c0e7
to
a1aff9e
Compare
a1aff9e
to
6fe9b99
Compare
fix(eda.plot_missing & eda.plot_correlation): based on the comments proposed by the lab members
fix(eda.plot_missing & eda.plot_correlation): based on the comments proposed by the lab members
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: