Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Classic Support #65

Closed
ManneN1 opened this issue Aug 9, 2019 · 12 comments
Closed

Feature Request: Classic Support #65

ManneN1 opened this issue Aug 9, 2019 · 12 comments
Assignees
Labels
Completed This task has been completed. Enhancement A feature request or improvement.

Comments

@ManneN1
Copy link

ManneN1 commented Aug 9, 2019

Hello,

Will Masque be updated for Classic WoW (1.13)? If so, is there an ETA?

Best Regards,
ManneN

@StormFX
Copy link
Member

StormFX commented Aug 9, 2019

I won't know until it's released.

@ManneN1
Copy link
Author

ManneN1 commented Aug 9, 2019

Until Classic WoW is released?

If it's of any help the final stress test is live and available to everyone with an active subscription.

@StormFX
Copy link
Member

StormFX commented Aug 9, 2019

I only test/update on live servers.

@qhilmv
Copy link

qhilmv commented Aug 10, 2019

I tried the latest stable version (v8.0.1) and it seems to be working without any problems.

@StormFX
Copy link
Member

StormFX commented Aug 10, 2019

I appreciate it. I'll need to test the latest version due to some additional API that was added. Hopefully, I'll be able to disable some features with a simple version check, if necessary. I really can't be bothered with maintaining two separate versions.

@ManneN1
Copy link
Author

ManneN1 commented Aug 12, 2019

Sure, it works by itself. It does however not work together with Bartender (updated for Classic). I got it working with Dominos, but with a whole bunch of errors.

Good luck on updating/maintaining the addon.

@qhilmv
Copy link

qhilmv commented Aug 12, 2019

Well, I'm using (or I used) Masque with Bartender and got no errors.
Maybe you used a wrong/incompatible version of Bartender4. Mine is "v4.8.3-19-classic" (alpha build) and it's not even the newest one for classic.

@StormFX
Copy link
Member

StormFX commented Aug 23, 2019

It looks like most of the API that Masque uses is intact, so I've made a few minor tweaks and released a beta for Classic.

@StormFX StormFX self-assigned this Aug 23, 2019
@StormFX StormFX added the Enhancement A feature request or improvement. label Aug 23, 2019
@qhilmv
Copy link

qhilmv commented Aug 27, 2019

Hey StormFX,
I tested your Classic version of Masque yesterday but it didn't work. No option entry, no chat commands, nothing. I reinstalled the older version (retail) to make it work again.

@StormFX
Copy link
Member

StormFX commented Aug 27, 2019

I just loaded up Classic with the Masque beta and BT4's Classic release and it's working fine.

@qhilmv
Copy link

qhilmv commented Aug 27, 2019

Well, I'll try it again later. I guess, I know what the problem was.

@StormFX StormFX added the Fixed This issue has been fixed. label Sep 2, 2019
@StormFX
Copy link
Member

StormFX commented Sep 2, 2019

Since this is already implemented, I'm closing this.

@StormFX StormFX closed this as completed Sep 2, 2019
@StormFX StormFX added Completed This task has been completed. and removed Fixed This issue has been fixed. labels Sep 1, 2020
@StormFX StormFX added this to the Release: 8.2.7 milestone Apr 27, 2022
@StormFX StormFX changed the title Classic Support Feature Request: Classic Support Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed This task has been completed. Enhancement A feature request or improvement.
Projects
Archived in project
Development

No branches or pull requests

3 participants