Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release: 0.10.x #80

Merged
merged 47 commits into from
Sep 8, 2023
Merged

Release: 0.10.x #80

merged 47 commits into from
Sep 8, 2023

Commits on Sep 8, 2023

  1. fix(native_image): fix C++ toolchain env setup 

    Instead of relying on the default shell env, get the environment
variables declared by the C++ toolchain. On macOS, additionally use
`apple_support` to pass in `DEVELOPER_DIR`.

Since GraalVM sanitizes the environment, all variables are translated
into `-E` flags.

Signed-off-by: Sam Gammon <sam@elide.ventures>
    @fmeum @sgammon
    fmeum authored and sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    0476a2b View commit details
    Browse the repository at this point in the history

  2. fix: wrapped env-injection callable 

    - fix: move `lambda` to nested function declaration

Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    a669c67 View commit details
    Browse the repository at this point in the history

  3. fix: refactor to split classic vs modern rules 

    - fix: unwind combined implementation of classic/modern rules
- fix: classic rules should preserve older functionality
- fix: modern rules should use modern toolchain env
- fix: wrapped/injected `env` while still supporting bazel4
- chore: re-factor commons between old/new rules

Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    1b244e1 View commit details
    Browse the repository at this point in the history

  4. fix: cleanup after rule internal refactor 

    - fix: use legacy rules from legacy gvm
- chore: drop `MODULE-resolved.bzl`
- chore: update bzlmod lock
- chore: update lib/docs deps and rebuild docs
- chore: remove redundant calls in sample projects

Applied on top of #72

Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    6bd64c9 View commit details
    Browse the repository at this point in the history

  5. fix: compile environment for msvc/native-image 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    49cfb66 View commit details
    Browse the repository at this point in the history

  6. chore: refactor/extract native cc resolution logic 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    208fe35 View commit details
    Browse the repository at this point in the history

  7. chore: general cleanup 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    0e7cd70 View commit details
    Browse the repository at this point in the history

  8. chore: run buildifier 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    ddfc471 View commit details
    Browse the repository at this point in the history

  9. fix: don't build/test tools by default 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    f284863 View commit details
    Browse the repository at this point in the history

  10. fix: make test should run all tests 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    f14396e View commit details
    Browse the repository at this point in the history

  11. fix: use default shell env on linux, too 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    f1760aa View commit details
    Browse the repository at this point in the history

  12. chore: update bzlmod locks 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    1a9dd90 View commit details
    Browse the repository at this point in the history

  13. chore: default_executable_name → executable_name 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    2ea70dc View commit details
    Browse the repository at this point in the history

  14. fix: no default tool for modern rules 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    e3e5b9a View commit details
    Browse the repository at this point in the history

  15. chore: rebuild apidoc 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    9aa2b21 View commit details
    Browse the repository at this point in the history

  16. feat(native_image): add static_zlib 

    When provided, the static zlib library will be used when Graal
statically links in zlib.

Signed-off-by: Sam Gammon <sam@elide.ventures>
    @fmeum @sgammon
    fmeum authored and sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    5e3c10e View commit details
    Browse the repository at this point in the history

  17. chore: run buildifier 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    9c3036d View commit details
    Browse the repository at this point in the history

  18. fix: rollback use_default_shell_env, remove msvc vars from tests 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    3355995 View commit details
    Browse the repository at this point in the history

  19. fix: fix modern build on Windows by adding cmd.exe to PATH 

    Signed-off-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Signed-off-by: Sam Gammon <sam@elide.ventures>
    @fmeum @sgammon
    fmeum authored and sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    2c556b8 View commit details
    Browse the repository at this point in the history

  20. fix(native_image): add missing _linux_constraint attribute 

    Signed-off-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Signed-off-by: Sam Gammon <sam@elide.ventures>
    @fmeum @sgammon
    fmeum authored and sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    a33235a View commit details
    Browse the repository at this point in the history

  21. fix!: add alias indirection for gvm toolchain 

    - fix: add `gvm` toolchain to toolchain config repo
- fix: add aliases from `graalvm` → toolchain targets
- fix: adjust instructions for registering toolchains
- fix: adjust workspace toolchain registration logic

Breaking change:
When registering toolchains in a Bzlmod installation of these rules,
the target `@graalvm//:all` must be changed to two toolchain
registrations, based on the desired functionality:

  Register the Java toolchain:
  register_toolchains("@graalvm//:jvm")

  Register the GVM toolchain:
  register_toolchains("@graalvm//:sdk")

Fixes and closes #66.

Relates-To: #66
Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    020ccef View commit details
    Browse the repository at this point in the history

  22. fix: run pr tests on non-mainline merge base 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    dde2158 View commit details
    Browse the repository at this point in the history

  23. test: add more feature integration tests 

    - test: add `java-toolchain` test, which exercises graalvm as the
  bazel tool/runtime java toolchain.

- test: add `components-ce` test, which downloads GVM Community
  components with dependencies.

- test: add `components-gvm` test, which downloads Oracle GVM
  components with `gu`.

- test: add `disabled_tests` with tests for earlier versions of
  bazel (coming soon), including `bazel1`, `bazel2`, and `bazel3`

- test: move most tests to GVM Community (except where noted)

Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    b9d2514 View commit details
    Browse the repository at this point in the history

  24. fix: default value for distribution 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    3d64e5f View commit details
    Browse the repository at this point in the history

  25. fix: don't set BAZEL_USE_CPP_ONLY_TOOLCHAIN in testing 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    6fe227c View commit details
    Browse the repository at this point in the history

  26. docs: document graalvm_repository attributes 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    57b6fb9 View commit details
    Browse the repository at this point in the history

  27. fix: stray parameter to _graal_updater_path 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    9411c4b View commit details
    Browse the repository at this point in the history

  28. chore: rebuild bzlmod lock and docs 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    bad638c View commit details
    Browse the repository at this point in the history

  29. feat: bazel settings integration 

    - feat: detect and honor `compilation_mode` flag
- feat: build with debug settings if `compilation_mode=dbg`
- feat: ability to build a shared library
- feat: build with `tool:coverage` if coverage is enabled and a
  test-only target is being built
- docs: add doc which explains shared library feature
- docs: add doc for built settings integration (more to come)

Relates-To: #78
Relates-To: #85
Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    8550e2a View commit details
    Browse the repository at this point in the history

  30. chore(deps): update dependency bazel_features to v1 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @renovate @sgammon
    renovate[bot] authored and sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    243f6d5 View commit details
    Browse the repository at this point in the history

  31. chore(deps): update dependency buildifier_prebuilt to v6.3.3 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @renovate @sgammon
    renovate[bot] authored and sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    489f58a View commit details
    Browse the repository at this point in the history

  32. chore(deps): update dependency io_bazel_stardoc to v0.6.2 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @renovate @sgammon
    renovate[bot] authored and sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    03de6e0 View commit details
    Browse the repository at this point in the history

  33. chore(deps): update dependency aspect_bazel_lib to v1.34.1 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @renovate @sgammon
    renovate[bot] authored and sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    1a8838c View commit details
    Browse the repository at this point in the history

  34. chore(deps): update googleapis digest to 2a10735 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @renovate @sgammon
    renovate[bot] authored and sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    7d1cbe2 View commit details
    Browse the repository at this point in the history

  35. chore: update bzlmod locks 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    483d19b View commit details
    Browse the repository at this point in the history

  36. test: extend components-ce to test js use 

    - test: add code to `components-ce` test to ensure `js`
  component is installed and usable

Co-authored-by: Mantas Indrašius <mantasi@wix.com>
Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon @mantasindrasius
    sgammon and mantasindrasius committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    d11eda2 View commit details
    Browse the repository at this point in the history

  37. docs: apidoc for toolchain internals 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    d9211cb View commit details
    Browse the repository at this point in the history

  38. feat: graalvm artifact mappings 

    - feat: add struct which defines maven coordinates for well-known
  graalvm maven dependencies

- feat: user-facing API to easily access these coordinates and
  declare them with `rules_jvm_external`

Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    77e33ca View commit details
    Browse the repository at this point in the history

  39. feat: alias macros for maven artifacts 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    bde07a5 View commit details
    Browse the repository at this point in the history

  40. test: add integration test for maven artifacts 

    - test: add integration test for artifact use
- test: add samples for each alias style
- chore: add maven artifact test to ci

Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    6e64502 View commit details
    Browse the repository at this point in the history

  41. chore: run buildifer 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    c41dc2d View commit details
    Browse the repository at this point in the history

  42. fix!: toolchain registration logic 

    - fix!: toolchain repo format -> `<name>_toolchains` (previously
  was `<name>_toolchain_config_repo`)
- fix: registration of toolchain targets from workspace hook -
  use toolchain targets directly instead of `@graalvm//:*` aliases
- docs: rebuild apidoc
- chore: update bzlmod lock

Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    8de4199 View commit details
    Browse the repository at this point in the history

  43. chore: prep release → 0.10.0 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    264a514 View commit details
    Browse the repository at this point in the history

  44. chore: update bzlmod locks 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    f4546de View commit details
    Browse the repository at this point in the history

  45. chore: run buildifier 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    a3d6d09 View commit details
    Browse the repository at this point in the history

  46. fix: typo in artifact mappings 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    11d9ff7 View commit details
    Browse the repository at this point in the history

  47. docs: maven artifact docs 

    Signed-off-by: Sam Gammon <sam@elide.ventures>
    @sgammon
    sgammon committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    0b12c7c View commit details
    Browse the repository at this point in the history