Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary command serialization #26

Closed
sgg opened this issue Oct 17, 2020 · 0 comments · Fixed by #27
Closed

Binary command serialization #26

sgg opened this issue Oct 17, 2020 · 0 comments · Fixed by #27
Assignees
@sgg

Comments

@sgg
Copy link
Owner

sgg commented Oct 17, 2020 •
edited
Loading

Command serialization is currently built on Display. This implicitly requires that commands be entirely UTF-8. To support i18n and binary payloads we should decouple serialization from Display.
@sgg sgg self-assigned this Oct 17, 2020
This was referenced Oct 17, 2020
Merged
Open
@sgg sgg closed this as completed in #27 Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgg sgg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduces Encode trait sgg/brokaw
1 participant
@sgg