Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

Add dockerfile? #16

Closed
Ognian opened this issue May 10, 2020 · 7 comments
Closed

Add dockerfile? #16

Ognian opened this issue May 10, 2020 · 7 comments

Comments

@Ognian
Copy link
Contributor

Ognian commented May 10, 2020

Have you thought of adding a dockerfile so that this can run on a Mac or even Windows?
Ognian

@sgielen
Copy link
Owner

sgielen commented May 11, 2020

I'm not sure if we can, because we use root privileges to perform loopback mounts. I think a privileged container could perhaps work. Would you like to give it a go? I can provide support where necessary and will certainly merge a change where a working Dockerfile (with some instructions in the README) is added.

@Ognian
Copy link
Contributor Author

Ognian commented May 13, 2020

Ok I tried this out and ended with the following:

...

2020-05-13 15:39:13 (5.54 MB/s) - 'deps/rpi-firmware-nonfree-master.zip' saved [110930819]

== Making image and filesystems... ==
/dev/mapper/control: open failed: No such device
Failure to communicate with kernel device-mapper driver.
Check that device-mapper is available in the kernel.
Incompatible libdevmapper 1.02.167 (2019-11-30) and kernel driver (unknown version).
device mapper prerequisites not met

If you want I can make a pull request with the work I did until now...

@Ognian
Copy link
Contributor Author

Ognian commented May 14, 2020

I've added some debug output:
image
and the output
image

looks like parts -a /dev/loopX is failing...
any ideas on this?

@Ognian
Copy link
Contributor Author

Ognian commented May 14, 2020

Maybe this can help...
I'm running privileged have devices /dev:/dev and cap_add: CAP_MKNOD

@Ognian
Copy link
Contributor Author

Ognian commented May 18, 2020

it should work now...
added pull request #18

@Ognian
Copy link
Contributor Author

Ognian commented May 31, 2020

@sgielen have you been able to review the PR already?

@sgielen
Copy link
Owner

sgielen commented Jul 6, 2020

Docker support landed in abd9ca3, thanks @Ognian!

@sgielen sgielen closed this as completed Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants