Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More explode refactoring #91

Merged
merged 5 commits into from
Mar 25, 2024
Merged

More explode refactoring #91

merged 5 commits into from
Mar 25, 2024

Conversation

jeromekelleher
Copy link
Contributor

This should be the final batch of breaking change to the intermediate format.

Main updates:

  • Rename to IntermediateColumnarFormat (Pickled chunks is an implementation detail)
  • Moved some more information into the metadata (chunk size, and compressor)
  • Changed default compressor to LZ4 (in my quick analysis, this leads to about twice the size of the ICF in about half the compression time. I'll follow up on this separately)

@jeromekelleher jeromekelleher merged commit ba70685 into sgkit-dev:main Mar 25, 2024
@jeromekelleher jeromekelleher deleted the more-explode-refactoring branch March 25, 2024 15:44
@jeromekelleher jeromekelleher mentioned this pull request Mar 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jeromekelleher