-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up Sphinx documentation #51
Conversation
LGTM. What's the plan for deploying to gh-pages? |
Use a GitHub Action to deploy to the gh-pages branch on every commit to master. I think that's the simplest thing to do until we have our first release and want different versions. |
Amazing, thanks @tomwhite! What are your thoughts on how we could incorporate docs from related packages like |
Good question. One option would be to generate self-contained docs for each package, and interlink them using |
@tomwhite do we need a follow up issue for that or is it easy enough to just incorporate into this PR and document for others? |
I think it needs some extra work, so I've opened #54 |
I fixed a broken link in the generated doc at https://pystatgen.github.io/sgkit/ |
I made changes so that the build will fail if Sphinx documentation warnings are introduced. I've also added a workflow to publish the docs to gh-pages when anything is committed to master (but I can't fully test that until this is merged). Reviews and suggestions welcome! |
I've rebased this. Any objections to merging this? It will allow us to press on with writing docs. |
- name: Check for Sphinx doc warnings | ||
run: | | ||
cd docs | ||
make html SPHINXOPTS="-W --keep-going" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a blocker on merging, but any particular reason for not making this strict? In my experience people writing docs will make lots of mistakes, and the only way to catch these is to have strict checking on and to verify it as part of CI. Otherwise the docs get cruddy pretty quickly when less experienced developers start contributing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could enable "nit-picky mode" (-n
). I tried doing this, but it generated some errors that will need a bit more work to fix. I've opened https://github.com/pystatgen/sgkit/issues/86
I think we should merge this ASAP - having some functional docs infrastructure is vital at this point. |
Thanks for the review @jeromekelleher |
This is the initial work to set up docs for the project, following discussion in #19.
:class:`xarray.Dataset`
To generate and view docs locally:
cd docs make html open _build/html/index.html